rsmith accepted this revision. This revision is now accepted and ready to land.
================ Comment at: lib/Lex/PPExpressions.cpp:104-105 @@ +103,4 @@ + // #else branch. Emit a warning about this undefined behavior. + if (beginLoc.isMacroID()) + PP.Diag(beginLoc, diag::warn_defined_in_macro); + ---------------- Move this down to the end of the function, after we've checked that we have a syntactically valid `defined` operator, to avoid duplicate diagnostics on a case like: #define FOO defined( #if FOO http://reviews.llvm.org/D15866 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
