erichkeane marked 2 inline comments as done. erichkeane added inline comments.
================ Comment at: test/CodeGenOpenCL/address-spaces-mangling.cl:7 +// RUN: %clang_cc1 %s -ffake-address-space-map -faddress-space-map-mangling=yes -triple x86_64-windows-pc -emit-llvm -o - | FileCheck -check-prefixes=MS_ASMANG,MS_ASMAN10 %s +// RUN: %clang_cc1 %s -cl-std=CL2.0 -ffake-address-space-map -faddress-space-map-mangling=yes -triple x86_64-windows-pc -emit-llvm -o - | FileCheck -check-prefixes=MS_ASMANG,MS_ASMAN20 %s +// RUN: %clang_cc1 %s -ffake-address-space-map -faddress-space-map-mangling=no -triple x86_64-windows-pc -emit-llvm -o - | FileCheck -check-prefixes=MS_NOASMANG,MS_NOASMAN10 %s ---------------- erichkeane wrote: > rnk wrote: > > I would replace `-triple x86_64-windows-pc` here and everywhere with > > `-triple x86_64-windows-itanium` (or gnu instead of itanium) to test the > > Itanium mangling on Windows. I don't think `x86_64-windows-pc` parses into > > a real triple. After all, "pc" is parsed as the vendor, which is supposed > > to be second. > Woops! I didn't mean to check this file in. It has some other nasty problems > that need to be fixed up, so I tested this feature in the > mangle-address-space. I'll still do this above. @rnk I tried this, but it changes off of the MicrosoftMangler and switches back to the Itanium mangling. Is there a better triple for testing microsoft mangling? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55715/new/ https://reviews.llvm.org/D55715 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
