arphaman marked 2 inline comments as done. arphaman added inline comments.
================ Comment at: lib/Driver/ToolChains/Darwin.cpp:2053 + return None; + } + return *SDKInfoOrErr; ---------------- steven_wu wrote: > We also has this InferredFromSDK when we infer deployment target, which can > be used as a fallback method. > > The result of parsing JSON should be available to InferredFromSDK in > deployment target setting. > > Bonus point is to set "-sdk_version" flag passing to ld64. Done. We're not planning to pass it down to the linker. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55673/new/ https://reviews.llvm.org/D55673 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
