NoQ updated this revision to Diff 178324.
NoQ retitled this revision from "[analyzer] MisusedMovedObjectChecker: Moving
the checker out of alpha state" to "[analyzer] MoveChecker Pt.10: Move the
checker out of alpha state.".
NoQ added a comment.
Rebase!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D38675/new/
https://reviews.llvm.org/D38675
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
test/Analysis/mismatched-iterator.cpp
test/Analysis/use-after-move.cpp
Index: test/Analysis/use-after-move.cpp
===================================================================
--- test/Analysis/use-after-move.cpp
+++ test/Analysis/use-after-move.cpp
@@ -1,30 +1,30 @@
-// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.cplusplus.Move -verify %s\
+// RUN: %clang_analyze_cc1 -analyzer-checker=cplusplus.Move -verify %s\
// RUN: -std=c++11 -analyzer-output=text -analyzer-config eagerly-assume=false\
// RUN: -analyzer-config exploration_strategy=unexplored_first_queue\
// RUN: -analyzer-checker debug.ExprInspection
-// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.cplusplus.Move -verify %s\
+// RUN: %clang_analyze_cc1 -analyzer-checker=cplusplus.Move -verify %s\
// RUN: -std=c++11 -analyzer-output=text -analyzer-config eagerly-assume=false\
// RUN: -analyzer-config exploration_strategy=dfs -DDFS=1\
// RUN: -analyzer-checker debug.ExprInspection
-// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.cplusplus.Move -verify %s\
+// RUN: %clang_analyze_cc1 -analyzer-checker=cplusplus.Move -verify %s\
// RUN: -std=c++11 -analyzer-output=text -analyzer-config eagerly-assume=false\
// RUN: -analyzer-config exploration_strategy=unexplored_first_queue\
-// RUN: -analyzer-config alpha.cplusplus.Move:WarnOn=KnownsOnly -DPEACEFUL\
+// RUN: -analyzer-config cplusplus.Move:WarnOn=KnownsOnly -DPEACEFUL\
// RUN: -analyzer-checker debug.ExprInspection
-// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.cplusplus.Move -verify %s\
+// RUN: %clang_analyze_cc1 -analyzer-checker=cplusplus.Move -verify %s\
// RUN: -std=c++11 -analyzer-output=text -analyzer-config eagerly-assume=false\
// RUN: -analyzer-config exploration_strategy=dfs -DDFS=1\
-// RUN: -analyzer-config alpha.cplusplus.Move:WarnOn=KnownsOnly -DPEACEFUL\
+// RUN: -analyzer-config cplusplus.Move:WarnOn=KnownsOnly -DPEACEFUL\
// RUN: -analyzer-checker debug.ExprInspection
-// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.cplusplus.Move -verify %s\
+// RUN: %clang_analyze_cc1 -analyzer-checker=cplusplus.Move -verify %s\
// RUN: -std=c++11 -analyzer-output=text -analyzer-config eagerly-assume=false\
// RUN: -analyzer-config exploration_strategy=unexplored_first_queue\
-// RUN: -analyzer-config alpha.cplusplus.Move:WarnOn=All -DAGGRESSIVE\
+// RUN: -analyzer-config cplusplus.Move:WarnOn=All -DAGGRESSIVE\
// RUN: -analyzer-checker debug.ExprInspection
-// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.cplusplus.Move -verify %s\
+// RUN: %clang_analyze_cc1 -analyzer-checker=cplusplus.Move -verify %s\
// RUN: -std=c++11 -analyzer-output=text -analyzer-config eagerly-assume=false\
// RUN: -analyzer-config exploration_strategy=dfs -DDFS=1\
-// RUN: -analyzer-config alpha.cplusplus.Move:WarnOn=All -DAGGRESSIVE\
+// RUN: -analyzer-config cplusplus.Move:WarnOn=All -DAGGRESSIVE\
// RUN: -analyzer-checker debug.ExprInspection
#include "Inputs/system-header-simulator-cxx.h"
Index: test/Analysis/mismatched-iterator.cpp
===================================================================
--- test/Analysis/mismatched-iterator.cpp
+++ test/Analysis/mismatched-iterator.cpp
@@ -100,7 +100,7 @@
void good_move_find3(std::vector<int> &v1, std::vector<int> &v2, int n) {
auto i0 = v2.cend();
v1 = std::move(v2);
- v2.push_back(n);
+ v2.push_back(n); // expected-warning{{Method called on moved-from object of type 'std::vector'}}
std::find(v2.cbegin(), i0, n); // no-warning
}
@@ -125,6 +125,7 @@
auto i0 = v2.cbegin();
v1 = std::move(v2);
std::find(i0, v2.cend(), n); // expected-warning{{Iterators of different containers used where the same container is expected}}
+ // expected-warning@-1{{Method called on moved-from object of type 'std::vector'}}
}
void bad_insert_find(std::vector<int> &v1, std::vector<int> &v2, int n, int m) {
@@ -167,12 +168,14 @@
const auto i0 = ++v2.cbegin();
v1 = std::move(v2);
v2.erase(i0); // expected-warning{{Container accessed using foreign iterator argument}}
+ // expected-warning@-1{{Method called on moved-from object of type 'std::vector'}}
}
void bad_move_find2(std::vector<int> &v1, std::vector<int> &v2, int n) {
auto i0 = --v2.cend();
v1 = std::move(v2);
std::find(i0, v2.cend(), n); // expected-warning{{Iterators of different containers used where the same container is expected}}
+ // expected-warning@-1{{Method called on moved-from object of type 'std::vector'}}
}
void bad_move_find3(std::vector<int> &v1, std::vector<int> &v2, int n) {
Index: include/clang/StaticAnalyzer/Checkers/Checkers.td
===================================================================
--- include/clang/StaticAnalyzer/Checkers/Checkers.td
+++ include/clang/StaticAnalyzer/Checkers/Checkers.td
@@ -275,6 +275,9 @@
def CXXSelfAssignmentChecker : Checker<"SelfAssignment">,
HelpText<"Checks C++ copy and move assignment operators for self assignment">;
+def MoveChecker: Checker<"Move">,
+ HelpText<"Find use-after-move bugs in C++">;
+
} // end: "cplusplus"
let ParentPackage = CplusplusOptIn in {
@@ -303,9 +306,6 @@
HelpText<"Check for use of iterators of different containers where iterators "
"of the same container are expected">;
-def MoveChecker: Checker<"Move">,
- HelpText<"Find use-after-move bugs in C++">;
-
def UninitializedObjectChecker: Checker<"UninitializedObject">,
HelpText<"Reports uninitialized fields after object construction">;
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
