[PATCH] D55843: [CodeGen] Handle mixed-width ops in mixed-sign mul-with-overflow lowering

[Eli Friedman via Phabricator via cfe-commits]

efriedma added a comment.

This looks reasonable.



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1265
+    NeedSExt = Op1Info.Signed;
+    NeedZExt = !Op1Info.Signed;
+  } else if (Op1Info.Width > Op2Info.Width) {
----------------
This is a weird way to express this... could you instead compute the width of 
the signed operand and the unsigned operand, and compare those?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55843/new/

https://reviews.llvm.org/D55843



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits