aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: test/Sema/pragma-pipeline.cpp:3
+
+#pragma clang loop pipeline(disable) /* expected-error {{expected
unqualified-id}} */
+int main() {
----------------
alexey.lapshin wrote:
> aaron.ballman wrote:
> > I think this error is pretty unfortunate -- it doesn't really help the user
> > to understand what's wrong with their code. Can it be improved?
> Agreed, this does not look very informative. It surely can be improved.
> Though it looks like not related to my fix. My fix is to add two additional
> loop hints. That kind of diagnostic related to all loop hints "clang loop".
> I.e. all pragmas "clang loop" can be checked for various cases and for better
> diagnostic. It looks like separate task. But OK, I will check that case.
That's a fair point -- I'm fine with doing that work in a separate patch. I
don't think we need to hold this patch up further for it, anyway.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55710/new/
https://reviews.llvm.org/D55710
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
