ilya-biryukov added inline comments.

================
Comment at: clangd/index/Background.cpp:309
   for (const auto &I : *Index.Sources) {
+    // We already have the map from uris to absolutepaths in the cache,
+    // therefore traverse Index.Sources rather than Files to get rid of 
absolute
----------------
If this the only reason we're traversing `Index.Sources`? If so, I suggest 
removing this comment and traversing `Files` instead.
This would make the code more straightforward and would definitely cost us only 
a negligible performance penalty.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56592/new/

https://reviews.llvm.org/D56592



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to