aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D55394#1356941 <https://reviews.llvm.org/D55394#1356941>, @rjmccall wrote:

> This is the AST dumper.  This is not a user feature.


Clang developers are users, too. However, the AST dumping does get used a bit 
by non-Clang developers too (such as people using clang-query, who see AST 
output).

> If I'm debugging a clang bug and calling `D->dump()`, I think it'll be just 
> as clear as it used to be what the `ObjCTypeParamDecl` lines mean.

Fantastic, that's the key bit. Thank you for weighing in!

If John doesn't think the change in output will cause confusion for people more 
familiar with ObjC, then I'm good with these changes.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55394/new/

https://reviews.llvm.org/D55394



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D55394: Re-order typ... Aaron Ballman via Phabricator via cfe-commits

Reply via email to