aaron.ballman added inline comments.
================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:277-280
+def warn_msp430_interrupt_attribute : Warning<
+ "MSP430 'interrupt' attribute only applies to functions that have "
+ "%select{no parameters|a 'void' return type}0">,
+ InGroup<IgnoredAttributes>;
----------------
krisb wrote:
> aaron.ballman wrote:
> > I'd fold this in to the preceding diagnostics using `%select{}`. Perhaps
> > the new diagnostic name should be
> > `warn_interrupt_attribute_invalid_subject` or some such?
> I thought about this but decided to not touch other targets in this patch.
> So, I'd prefer to make a follow-up patch to refactor these 3 diagnostics (for
> mips, riscv and msp430) to a single. What do you think?
I'm fine with that, thanks!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56663/new/
https://reviews.llvm.org/D56663
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
