eugenis marked an inline comment as done.
eugenis added inline comments.
================
Comment at: cfe/trunk/lib/Driver/ToolChains/Linux.cpp:814
+bool Linux::isPIEDefault() const {
+ return (getTriple().isAndroid() && !getTriple().isAndroidVersionLT(16)) ||
+ getSanitizerArgs().requiresPIE();
----------------
pcc wrote:
> Why only on API level >= 16? If I create an executable targeting an older API
> level, it should still work on higher API levels.
Because it needs to work on lower API levels, too. I think at some point PIE
was actually not supported, so there is no good default that works for everyone.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D38430/new/
https://reviews.llvm.org/D38430
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
