ilya-biryukov added inline comments.
================
Comment at: include/clang/Tooling/ArgumentsAdjusters.h:69
+/// Gets an argument adjuster which strips plugin related command line
+/// arguments.
----------------
Maybe put the function before `combineAdjusters`?
The latter is a function that works on two adjusters, therefore a bit different
from the rest, which are adjusters themselves.
================
Comment at: include/clang/Tooling/ArgumentsAdjusters.h:71
+/// arguments.
+ArgumentsAdjuster getClangStripPluginsAdjuster();
+
----------------
Maybe drop "clang" from the name? `getStripPluginsAdjuster()?
================
Comment at: lib/Tooling/ArgumentsAdjusters.cpp:111
+// Strips plugin related command line arguments.
+ArgumentsAdjuster getClangStripPluginsAdjuster() {
----------------
remove the comment? we already have one in the header
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56856/new/
https://reviews.llvm.org/D56856
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
