aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
In D57104#1369885 <https://reviews.llvm.org/D57104#1369885>, @riccibruno wrote: > In D57104#1369864 <https://reviews.llvm.org/D57104#1369864>, @steveire wrote: > > > Thanks, but I don't see the factored out changes in the repo. Are you going > > to commit those first? > > > > Also, please factor out the introduction and use of `::Create`. It seems to > > be unrelated to the trailing objects change. > > > I was planning to yes. I don't agree that the introduction of `Create` is > unrelated. It is very much part of the changes > since the introduction of the trailing objects implies the need to do a > placement new, which implies the need to > use a `Create` function. Also see pretty much every other patch which > introduced trailing objects for the > statement/expression nodes. +1, the changes to the `Create` methods are germane to this review. This LGTM, thank you for working on it! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57104/new/ https://reviews.llvm.org/D57104 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
