ebevhan added inline comments.
================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:141
+ (RHSType->isFixedPointType() &&
+ LHSType->isFixedPointOrIntegerType());
+ }
----------------
Can't it just be `LHSType->isFixedPointType() || RHSType->isFixedPointType()`?
I don't think there are cases where one is a fixed-point type and the other is
not an integer or another fixed-point type, so if one is fixed-point then you
already know it's a fixed-point operation.
================
Comment at: clang/test/Frontend/fixed_point_comparisons.c:56
+
+void TestComparisons() {
+ short _Accum sa;
----------------
Missing saturating and saturating/non-saturating comparisons. I'd like to see
the differences between unsigned padding and not there, if there are any.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57219/new/
https://reviews.llvm.org/D57219
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
