alexfh added inline comments.
================
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300
+/// matches `x.m()` and `p->m()`.
+AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType,
+ clang::ast_matchers::internal::Matcher<clang::QualType>,
----------------
The name of the matcher doesn't tell me much. I had to carefully read the
documentation to understand what is it about. I don't have a name that would
raise no questions and wouldn't be too verbose at the same time, but a bit of
verbosity wouldn't hurt I guess. How about `objectTypeAsWritten`?
================
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3301
+AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType,
+ clang::ast_matchers::internal::Matcher<clang::QualType>,
+ InnerMatcher, 0) {
----------------
nit: `clang::` and `clang::ast_matchers::` are unnecessary. Same below
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56851/new/
https://reviews.llvm.org/D56851
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
