aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some formatting nits.
================
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:2184
+ if (const MemberSpecializationInfo *MSInfo =
+ A->getMemberSpecializationInfo()) {
+ Loc = MSInfo->getPointOfInstantiation();
----------------
Elide braces
================
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:2186
+ Loc = MSInfo->getPointOfInstantiation();
+ } else if (const auto *Spec =
+ dyn_cast<ClassTemplateSpecializationDecl>(A)) {
----------------
Elide braces
================
Comment at:
test/CodeGenCXX/attr-used-member-function-implicit-instantiation.cpp:2
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-llvm -O0 -o - %s \
+// RUN: | FileCheck %s
+
----------------
I'd go ahead and leave this on the same line as the previous RUN line. We're
often less picky about 80-col limits for RUN lines unless they're obnoxiously
long. You can drop the `-O0` from the RUN line as well (I believe).
================
Comment at:
test/CodeGenCXX/attr-used-member-function-implicit-instantiation.cpp:6
+// classes
+namespace InstantiateUsedMemberDefinition {
+ template <typename T> struct S {
----------------
You should run the patch through clang-format -- the indentation looks
incorrect here.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56928/new/
https://reviews.llvm.org/D56928
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
