ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM, just a few nits ================ Comment at: include/clang/Frontend/PrecompiledPreamble.h:286 virtual std::unique_ptr<PPCallbacks> createPPCallbacks(); + /// Adds the returned CommentHandler to PreProcessor if not null. + virtual CommentHandler *getCommentHandler(); ---------------- NIT: this function does not add anything by itself, maybe rephrase to avoid confusion, e.g. `The returned CommentHandler will be added to the preprocessor if not null`. NIT: Use `Preprocessor` or `preprocessor`. It seems to be always spelled as a single word. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57507/new/ https://reviews.llvm.org/D57507 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
