This revision was automatically updated to reflect the committed changes. Dor1s marked an inline comment as done. Closed by commit rC352890: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections. (authored by Dor1s, committed by ).
Changed prior to commit: https://reviews.llvm.org/D57474?vs=184766&id=184770#toc Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57474/new/ https://reviews.llvm.org/D57474 Files: docs/SanitizerCoverage.rst Index: docs/SanitizerCoverage.rst =================================================================== --- docs/SanitizerCoverage.rst +++ docs/SanitizerCoverage.rst @@ -144,6 +144,11 @@ **Experimental, may change or disappear in future** +**Note:** this instrumentation might be incompatible with dead code stripping +(``-Wl,-gc-sections``) for linkers other than LLD, thus resulting in a +significant binary size overhead. For more information, see +`Bug 34636 <https://bugs.llvm.org/show_bug.cgi?id=34636>`_. + With ``-fsanitize-coverage=pc-table`` the compiler will create a table of instrumented PCs. Requires either ``-fsanitize-coverage=inline-8bit-counters`` or ``-fsanitize-coverage=trace-pc-guard``.
Index: docs/SanitizerCoverage.rst =================================================================== --- docs/SanitizerCoverage.rst +++ docs/SanitizerCoverage.rst @@ -144,6 +144,11 @@ **Experimental, may change or disappear in future** +**Note:** this instrumentation might be incompatible with dead code stripping +(``-Wl,-gc-sections``) for linkers other than LLD, thus resulting in a +significant binary size overhead. For more information, see +`Bug 34636 <https://bugs.llvm.org/show_bug.cgi?id=34636>`_. + With ``-fsanitize-coverage=pc-table`` the compiler will create a table of instrumented PCs. Requires either ``-fsanitize-coverage=inline-8bit-counters`` or ``-fsanitize-coverage=trace-pc-guard``.
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
