compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed.
================ Comment at: lib/Basic/Targets/AMDGPU.cpp:263 MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64; +#if _WIN32 + WCharType = UnsignedShort; ---------------- This seems wrong. This means that if you built on Linux, you get a different `wchar_t` type. You should be checking the triple and setting this accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57831/new/ https://reviews.llvm.org/D57831 _______________________________________________ cfe-commits mailing list firstname.lastname@example.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits