lebedev.ri added a comment.

In D57915#1389549 <https://reviews.llvm.org/D57915#1389549>, @TomTan wrote:

> Added the tests back. Clang IR should not lower these to bswap calls because 
> they are global library functions. It might be slower to make the call to 
> library function than bswap, but this is the same for other architectures 
> supported by Windows. And just redefine global library function triggers link 
> error in some scenarios.


I think there is some deeper reasoning is being omitted here.
//Why// does the fact that those are "global library functions" bans clang from 
lowering them into IR?
(and thus, "prevents" LLVM form doing optimizations)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57915/new/

https://reviews.llvm.org/D57915



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to