ilya-biryukov added a comment.

In D57739#1390252 <https://reviews.llvm.org/D57739#1390252>, @sammccall wrote:

> I agree with this concern, and don't think this is an appropriate layer to be 
> aware of styling or failing on format errors. Can we consider moving the 
> formatting to clangdserver as originally planned?


`clang-format` seems to be somewhat stable, do we actually expect that to be a 
large problem in practice?
On the other side, I can't imagine any clients that don't need formatting? E.g. 
it's nice when tests give the same results as one would see in the final clangd 
and tests don't go through `ClangdServer`.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57739/new/

https://reviews.llvm.org/D57739



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to