mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land.
lgtm with a comment (and perhaps an assertion). ================ Comment at: clang/lib/CodeGen/CGVTables.cpp:777 + CGM.setGVProperties(VTable, RD); + ---------------- Give it a comment pointing out the importance of doing this after createVTableInitializer rather than before. If there's an easy way to add an "assert(is defined)" before setGVProperties to go with the comment, do that too. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58010/new/ https://reviews.llvm.org/D58010 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
