nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
Please, no more patches without context. This one was actually easy to review
without context and the comments are minor, so I'm fine with these being
addressed on the commit.
================
Comment at: lib/Basic/Targets/PPC.cpp:318
+ Features["spe"] = llvm::StringSwitch<bool>(CPU)
+ .Case("e500", true)
+ .Case("8548", true)
----------------
The `e500v2` that you added doesn't support SPE?
================
Comment at: test/Misc/target-invalid-cpu-note.c:82
// PPC-SAME: 603e, 603ev, 604, 604e, 620, 630, g3, 7400, g4, 7450, g4+, 750,
-// PPC-SAME: 970, g5, a2, a2q, e500mc, e5500, power3, pwr3, power4, pwr4,
+// PPC-SAME: 970, g5, a2, a2q, e500, e500mc, e5500, power3, pwr3, power4, pwr4,
// PPC-SAME: power5, pwr5, power5x, pwr5x, power6, pwr6, power6x, pwr6x,
power7,
----------------
I think you may have missed adding `8548` to this line or above. Of course, the
test should still pass, but we should add it.
================
Comment at: test/Preprocessor/init.c:7021
+//
+// PPC32-SPE:#define __SPE__ 1
+//
----------------
Please add a check for the other predefined macro you added.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49754/new/
https://reviews.llvm.org/D49754
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
