jyknight added a comment. In D58548#1407164 <https://reviews.llvm.org/D58548#1407164>, @dexonsmith wrote:
> I like this idea, and I don’t think the textual IR central is too important. > A few things: > > - Changes to the IR should always be discussed on llvm-dev. Did this already > happen? I sent a message ("Improving textual IR format for nameless blocks") concurrently with sending this review, and will wait a bit to make sure there's no objections. > - Please update LangRef. Done. > - Did you write a script for updating the test cases? If so, you might > consider attaching it to the RFC and linking to it from the commit message as > a courtesy to downstream maintainers. Nope, I didn't; there were few enough instances that it didn't seem worth scripting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58548/new/ https://reviews.llvm.org/D58548 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits