martong added inline comments.
================ Comment at: clang/unittests/AST/ASTImporterTest.cpp:1344 + + EXPECT_EQ(FromChooseExpr->isConditionTrue(), ToChooseExpr->isConditionTrue()); +} ---------------- To compensate the skipping of the template test, perhaps we should have another expectation for the condition dependency of the expression: ``` EXPECT_EQ(FromChooseExpr->isConditionDependent(), ToChooseExpr->isConditionDependent()); ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58663/new/ https://reviews.llvm.org/D58663 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
