void added a comment. My opinion doesn't carry as much weight as others who are more familiar with the front-end code, but LGTM.
One question, the code you added looks similar. Is there a way to extrapolate it into its own function? Maybe yet another `EvaluateAs*` method? ================ Comment at: clang/lib/Sema/SemaStmtAsm.cpp:389 + + // For compatibility with GCC, we also allows pointers that would be + // integral constant expressions if they were cast to int. ---------------- s/allows/allow/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58821/new/ https://reviews.llvm.org/D58821 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
