lewissbaker added inline comments.
================
Comment at: lib/Sema/SemaCoroutine.cpp:197-200
- if (S.isUnevaluatedContext()) {
- S.Diag(Loc, diag::err_coroutine_unevaluated_context) << Keyword;
- return false;
- }
----------------
Does removing this check now mean that we're not checking that `co_return`
statements don't appear in unevaluated contexts?
Or is that already handled elsewhere by the fact that `co_return` statements
are not expressions and are therefore detected earlier as a grammar violation
when parsing `sizeof()` expression?
================
Comment at: lib/Sema/SemaCoroutine.cpp:675
+ // Second emphasis of [expr.await]p2: must be outside of an exception
handler.
+ if (S.getCurScope()->getFlags() & Scope::CatchScope) {
+ S.Diag(Loc, diag::err_coroutine_within_handler) << Keyword;
----------------
modocache wrote:
> EricWF wrote:
> > We can still build a valid AST after encountering this error, no?
> >
> >
> I believe so. Just to be clear: you'd like me to continue building the AST
> even after emitting this error diagnostic? My understanding is that most of
> this file bails soon after any error is encountered (correct me if that's
> wrong). I'm happy to change that, but I wonder if it'd be better to do that
> in a separate diff...?
Do the scope flags reset when a lambda occurs within a catch-block?
eg. The following should still be valid.
```
try { ... }
catch (...) {
[]() -> task { co_await foo(); }();
}
```
================
Comment at: test/SemaCXX/coroutines.cpp:299-311
// FIXME: The spec says this is ill-formed.
void operator=(CtorDtor&) {
co_yield 0; // expected-error {{'co_yield' cannot be used in a copy
assignment operator}}
}
void operator=(CtorDtor const &) {
co_yield 0; // expected-error {{'co_yield' cannot be used in a copy
assignment operator}}
}
----------------
Not related to this diff, but...
I don't think that these should be ill-formed.
According to N4775 there are only exclusions added for [class.ctor] and
[class.dtor].
I can't see anything in the spec that says that assignment special member
functions cannot be coroutines.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59076/new/
https://reviews.llvm.org/D59076
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
