whisperity added inline comments.
================ Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:329 + + // Insertation was successful -- CmdLineOption's constructor will validate + // whether values received from plugins or TableGen files are correct. ---------------- Insertion ================ Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:340 + if (OptionType == "bool") { + if (SuppliedValue != "true" && SuppliedValue != "false") { + if (AnOpts.ShouldEmitErrorsOnInvalidConfigValue) { ---------------- Does this mean that we no longer can give "1" and "0" for boolean checker options? Or was that //Tidy// who allowed such in the first place? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits