aaron.ballman added inline comments.

================
Comment at: clang/test/Parser/objc-static-assert.m:29
+struct S {
+  @defs(A);
+};
----------------
Given that static assertions are member declarations of a struct, should this 
"replay" the static asserts from the interface (including failing the 
assertions)?


================
Comment at: clang/test/Parser/objc-static-assert.mm:4
+
+#if !__has_feature(objc_c_static_assert)
+#error failed
----------------
Why do we expect `objc_c_static_assert` to be a supported feature in ObjC++? I 
would have expected this as an extension, but not a feature.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59223/new/

https://reviews.llvm.org/D59223



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to