kadircet marked an inline comment as done. kadircet added inline comments.
================ Comment at: clang/lib/AST/TypePrinter.cpp:1646 + break; + case TemplateArgument::ArgKind::Type: + A.getTypeSourceInfo()->getType().print(OS, PP); ---------------- ilya-biryukov wrote: > Maybe simplify the switch to: > ``` > if (A.getKind() == TemplateArgument::ArgKind::Type) { > A.getTypeSourceInfo()->getType().print(OS, PP); > return; > } > A.getArgument().print(PP, OS); > ``` > It was rather to catch any changes in the ArgKind at compile-time, still can do if you think this should not cause any problems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59354/new/ https://reviews.llvm.org/D59354 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits