rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
Looks good to me. Let's wait for @jyknight though. ================ Comment at: lib/Headers/ia32intrin.h:120 + +#ifndef _MSC_VER +/* Select the correct function based on the size of long. */ ---------------- Can you add comments here indicating that these are already provided as builtins for MSVC, so these macros are unnecessary? ================ Comment at: lib/Headers/ia32intrin.h:133 + +#define _rotwl(a,b) __rolw((a), (b)) +#define _rotwr(a,b) __rorw((a), (b)) ---------------- And, add a comment here indicating that these are not builtins, so they are provided in all modes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59346/new/ https://reviews.llvm.org/D59346 _______________________________________________ cfe-commits mailing list email@example.com https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits