erik.pilkington added inline comments.

Comment at: clang/include/clang/Basic/
+def PassDynamicObjectSize : InheritableParamAttr {
+  let Spellings = [Clang<"pass_dynamic_object_size">];
+  let Args = [IntArgument<"Type">];
aaron.ballman wrote:
> Why use a separate attribute as opposed to a separate spelling and an 
> accessor on `PassObjectSizeAttr` to ask whether it's dynamic or not? The two 
> attributes seem to have identical semantics aside from which builtin is 
> called, so I think it makes sense to use the same semantic attribute type.
Oh, I didn't even know that was possible. I guess thats why `Spellings` is an 
array :). That simplifies the implementation too, now we can ditch 


cfe-commits mailing list

Reply via email to