aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from a small nit. ================ Comment at: include/clang/Analysis/Analyses/ThreadSafety.h:127 + SourceLocation LocLocked, SourceLocation Loc) {} ---------------- Can you rename this one to `LocUnlocked` to mirror the new parameter? ================ Comment at: lib/Sema/AnalysisBasedWarnings.cpp:1690 + SourceLocation LocLocked, SourceLocation Loc) override { if (Loc.isInvalid()) ---------------- Same suggestion here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59455/new/ https://reviews.llvm.org/D59455 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits