Szelethus added a comment.

In D59457#1433180 <https://reviews.llvm.org/D59457#1433180>, 
@baloghadamsoftware wrote:

> Please rename the patch. Its name does not really express its content.


Good point, sorry about that.

In D59457#1433816 <https://reviews.llvm.org/D59457#1433816>, @xazax.hun wrote:

> I did not check the patch yet but wanted to point out that we might not want 
> to rush about renaming all the variables until the community decides on the 
> coding guideline, see https://reviews.llvm.org/D59251


I wonder why this wasn't posted on cfe-dev. In any case, most of the variables 
are capitalized, there still is a consistency argument. Refactoring all the 
dependent patches would also be a pain in the buttocks for little gain.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59457/new/

https://reviews.llvm.org/D59457



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to