craig.topper added a comment.

In D28213#1435542 <https://reviews.llvm.org/D28213#1435542>, @efriedma wrote:

> It's kind of awkward to use ">=" on a CPU enum, but yes, that's the right 
> idea.


I agree, but we do the same thing on the "__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8" 
define in X86.cpp.

Applying that diff does cause 3 tests to fail. I'll try to work through that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D28213/new/

https://reviews.llvm.org/D28213



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to