MyDeveloperDay marked an inline comment as done.
MyDeveloperDay added inline comments.


================
Comment at: include/clang/Basic/TokenKinds.h:80
          K == tok::utf8_string_literal || K == tok::utf16_string_literal ||
-         K == tok::utf32_string_literal;
 }
----------------
klimek wrote:
> This change looks pretty good, minus the changes outside Format/ :( Do you 
> see any chance to fix this by extending the token merging? It's unlikely that 
> the community will be convinced to add some minor parts of C# to clang proper 
> just to support clang-format.
I know I'm a little nervous about having this code out where it might break the 
actual compiler

Before I got stuck with how C# does its verbatim and interpolated strings 
especially when \ is in a string just before the "

let me go back and see if I can't do this with merging the tokens now I know a 
little more


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58404/new/

https://reviews.llvm.org/D58404



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to