apazos added inline comments.
Herald added subscribers: benna, psnobl.
================
Comment at: lib/Driver/ToolChains/Clang.cpp:1803
+
+ // Forward the -msmall-data-limit= option.
+ if (Arg *A = Args.getLastArg(options::OPT_G)) {
----------------
Might be simpler to just set it to 0, and if G is present in the command line,
and the other flags are not present, then you change the value. Also, might be
good to print a warning to let user know -G is ignored?
================
Comment at: lib/Driver/ToolChains/RISCVToolchain.cpp:117
+ if (D.isUsingLTO()) {
+ assert(!Inputs.empty() && "Must have at least one input.");
----------------
This change is not part of this patch.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57497/new/
https://reviews.llvm.org/D57497
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
