jfb marked an inline comment as done. jfb added inline comments.
================ Comment at: test/SemaObjCXX/no-crash-thread-safety-analysis.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wthread-safety -Wno-objc-root-class %s + ---------------- aaronpuchert wrote: > Test is fine for me, but I would like if you could integrate it with the > existing test/SemaObjCXX/warn-thread-safety-analysis.mm. The thread safety > analysis requires a bit of setup, that's why we tend to keep the tests in one > file. I'll admit that the C++ tests have grown quite large, but for ObjC++ > it's still very manageable. Sure thing! I created a header that's shared and simplified this repro a bit. I validated that the shared code was crashing before and this fixes the crash. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59523/new/ https://reviews.llvm.org/D59523 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
