riccibruno accepted this revision.
riccibruno added a comment.
This revision is now accepted and ready to land.

Great! Since this already received one round of reviews I guess this looks okay.



================
Comment at: test/SemaCXX/exceptions.cpp:25
+      int ref = k;
+    }
     int j = i; // expected-error {{use of undeclared identifier 'i'}}
----------------
I am wondering if there is already a test which checks systematically that a 
declaration which shadows another declaration is valid/invalid. I am not seeing 
such a systematic test, but it might be a nice addition (though that it clearly 
out of scope for this patch)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59752/new/

https://reviews.llvm.org/D59752



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to