stephanemoore marked 2 inline comments as done. stephanemoore added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:110 + "invoke a superclass initializer?") + << Message->getMethodDecl() + << FixItHint::CreateReplacement(Message->getSourceRange(), ---------------- stephanemoore wrote: > aaron.ballman wrote: > > Is there a %0 missing from the diagnostic for this method declaration > > you're passing in? > Good catch! That's egg on my face 😅🥚 > > I think I was internally conflicted over specifically mentioning -[NSObject > self] versus using the method declaration of the message expression and > somehow got stuck halfway in-between 😓 I think it's better to mention the > method declaration of the message. Let me know if you think that I should > instead mention -[NSObject self]. Whoops; I forgot to update the message in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59806/new/ https://reviews.llvm.org/D59806 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
