ymandel added a comment.

In D59376#1454617 <https://reviews.llvm.org/D59376#1454617>, @ilya-biryukov 
wrote:

> Keeping it **only** in the cpp file also LG if we don't plan to have other 
> usages for now, but please remove the version from `FixIt.h`


The Stencil library will need this as well and I've heard from another user 
who's already using this (a standalone tool, not in clang), so it seems to have 
a general value.  Might the fixit library belong in Core?  I have a whole bunch 
more utility functions coming along, so we need a place for them as well.

I propose that I create a new library in Core with `getExtendedRange()` and 
remove it from FixIt. The other  utility functions that I need will also go 
there.  We can separately investigate moving the remaining pieces of FixIt into 
Core.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59376/new/

https://reviews.llvm.org/D59376



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to