sammccall added inline comments.
================
Comment at: unittests/clangd/ClangdTests.cpp:1082
+ EXPECT_EQ(Res.Context, CodeCompletionContext::CCC_Recovery);
+ ASSERT_TRUE(Server.blockUntilIdleForTest());
+ EXPECT_THAT(cantFail(runCodeComplete(Server, FooCpp, Code.point(),
----------------
sammccall wrote:
> do I understand right that this test is currently racy?
Sorry, missed your comment. Test LG
================
Comment at: unittests/clangd/ClangdTests.cpp:1080
+ // This will make compile command broken and preamble absent.
+ CDB.ExtraClangFlags = {"yolo.cc"};
+ Server.addDocument(FooCpp, Code.code());
----------------
(`-this-flag-does-not-exist` might be clearer)
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59811/new/
https://reviews.llvm.org/D59811
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
