Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Great! Thanks!
================
Comment at: lib/CodeGen/CGBuiltin.cpp:3709
+ llvm::Value *EventWaitList = nullptr;
+ if (E->getArg(4)->isNullPointerConstant(
+ getContext(), Expr::NPC_ValueDependentIsNotNull)) {
----------------
Just a minor issue of style, you could probably use a common lambda helper
here. Although it's only used in this two places so definitely not that
critical. It might be helpful mainly if we need to fix something later...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59985/new/
https://reviews.llvm.org/D59985
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
