rjmccall added a reviewer: ahatanak. rjmccall added inline comments. Herald added a subscriber: dexonsmith.
================ Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:140 + QualType QT); + } // end namespace CodeGen ---------------- Would you mind calling these `get...` rather than `generate...`? It'd make it clearer that they will re-use an existing definition if possible. Otherwise this looks great, thanks! Akira, any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/ https://reviews.llvm.org/D60161 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
