Eugene.Zelenko added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/bugprone/UnhandledSelfAssignmentCheck.cpp:20 +void UnhandledSelfAssignmentCheck::registerMatchers(MatchFinder *Finder) { + + // We don't care about deleted, default or implicit operator implementations. ---------------- Unnecessary empty line. ================ Comment at: clang-tools-extra/clang-tidy/bugprone/UnhandledSelfAssignmentCheck.cpp:76 + const MatchFinder::MatchResult &Result) { + + const auto *MatchedDecl = ---------------- Unnecessary empty line. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-self-assignment.rst:6 + +Finds user-defined copy assignment operators which do not protect the code +against self-assignment either by checking self-assignment explicitly or ---------------- Please synchronize this statement with Release Notes. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-self-assignment.rst:10-12 +This check corresponds to the CERT C++ Coding Standard rule +`OOP54-CPP. Gracefully handle self-copy assignment +<https://wiki.sei.cmu.edu/confluence/display/cplusplus/OOP54-CPP.+Gracefully+handle+self-copy+assignment>`_. ---------------- alexfh wrote: > JonasToth wrote: > > It is worth an alias into the cert module. Please add this with this > > revision already. > Please add a corresponding alias into the cert module. See also other aliased checks for documentation examples. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-self-assignment.rst:41 + + +There are two common C++ patterns to avoid this problem. The first is ---------------- Unnecessary empty line. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-self-assignment.rst:66 + + +The second one is the copy-and-swap method when we create a temporary copy ---------------- Unnecessary empty line. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60507/new/ https://reviews.llvm.org/D60507 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits