kadircet marked an inline comment as done.
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/AST.cpp:112
if (!Out.str().empty()) {
- // FIXME(ibiryukov): do not show args not explicitly written by the user.
- if (auto *ArgList = getTemplateSpecializationArgs(ND))
----------------
ilya-biryukov wrote:
> Where did this FIXME go? Is this now fixed?
Yes, since `printTemplateArgsAsWritten` prints the args as written in the
code(see changes in file
clang-tools-extra/unittests/clangd/FindSymbolsTests.cpp, especially the tests
with a FIXME).
Of course it still has the caveat of frienddecls, but I think the fixme inside
`printTemplateArgsAswritten` is the one covering that case, not this one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59641/new/
https://reviews.llvm.org/D59641
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
