[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

[Luke Geeson via Phabricator via cfe-commits]

LukeGeeson added a comment.

couple of nits, besides from that LGTM



================
Comment at: lib/CodeGen/CGBuiltin.cpp:7813
   }
+  case NEON::BI__builtin_neon_vduph_lane_f16:{
+    return Builder.CreateExtractElement(Ops[0], EmitScalarExpr(E->getArg(1)),
----------------
nit: spacing between : and { 


================
Comment at: lib/CodeGen/CGBuiltin.cpp:7817
+  }
+  case NEON::BI__builtin_neon_vduph_laneq_f16:{
+    return Builder.CreateExtractElement(Ops[0], EmitScalarExpr(E->getArg(1)),
----------------
nit: spacing again


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60272/new/

https://reviews.llvm.org/D60272



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits