rjmccall added inline comments.
================
Comment at: lib/CodeGen/PatternInit.cpp:17
+
+llvm::Constant *patternFor(CodeGenModule &CGM, llvm::Type *Ty) {
+ // The following value is a guaranteed unmappable pointer value and has a
----------------
Please use a qualified declaration here instead of defining it in the namespace.
================
Comment at: lib/CodeGen/PatternInit.h:22
+
+llvm::Constant *patternFor(CodeGenModule&, llvm::Type*);
+
----------------
Please choose names that mean something outside of the mental context you were
in when you wrote the patch. :)
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60548/new/
https://reviews.llvm.org/D60548
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
