mmasten marked 2 inline comments as done.
mmasten added inline comments.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9615
+
+ std::string Buffer;
+ if (Fn->hasFnAttribute("vector-variants")) {
----------------
ABataev wrote:
> 1. Why this change is required?
> 2. Why not a `SmallString`?
This change is required to more clearly indicate which function names represent
simd function variants of the original scalar function. Previously, these
function names were just represented as individual strings. Example:
"_ZGVbM4l8__Z5add_1Pf", "_ZGVbN4l8__Z5add_1Pf", ... The attributes are now
represented as a key/value pair: "vector-variants"="_ZGVbM4l8__Z5add_1Pf,
_ZGVbN4l8__Z5add_1Pf, ...". Because the length of the string can now be quite a
bit longer, I used std::string. Is SmallString still appropriate?
================
Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:323
+
+// CHECK-NOT: _ZGV{{.+}}__Z1fRA_i
----------------
ABataev wrote:
> Hmm, a very strange update of the test, just quotes are removed and nothing
> else.
I can probably change the test to be more explicit in checking for
"vector-variants", if you think this would be better. The quotes were removed
because of the change to the attribute formatting. E.g., the function names
will no longer appear as individual strings, but as the key/value pair where
all function names will now appear within a single string.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D40577/new/
https://reviews.llvm.org/D40577
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
