alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a couple of nits.
================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:582
+ if (!L.hasValidLocation()) {
+ // Do we need to suppress our report for body-farmed functions as well?
+ // Or maybe attach the note to the call site instead?
----------------
Should this be marked with a FIXME?
================
Comment at: clang/test/Analysis/diagnostics/body-farm-crashes.c:1
+// RUN: %clang_analyze_cc1 -w -analyzer-checker=core\
+// RUN: -analyzer-output=text -verify %s
----------------
Add a space before the backslash.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60808/new/
https://reviews.llvm.org/D60808
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
