axzhang marked 3 inline comments as done.
axzhang added inline comments.
================
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69
+ IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)),
+ IgnoreListInit(Options.get("IgnoreListInit", false)) {}
----------------
hintonda wrote:
> hintonda wrote:
> > axzhang wrote:
> > > hintonda wrote:
> > > > You’re setting it false here.
> > > I thought that false was the default value if the options do not contain
> > > "IgnoreListInit"?
> > Do you have a test that passes this option? I didn’t see one.
> I could be wrong, but when you do an Options.get(), that looks at what was
> passed on the commandline, and if it wasn't found, it sets the default
> provided.
Fixed by changing the Options value to "1" instead of true in the
AbseilTidyModule
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55044/new/
https://reviews.llvm.org/D55044
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
